LGTM, but please fix the nits.
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc#newcode1456
src/mips/lithium-codegen-mips.cc:1456: // Correct the sign of the result
is the constant is negative.
nit, typo in comment: first 'is' -> 'if'
https://codereview.chromium.org/25050002/diff/1/src/mips/lithium-codegen-mips.cc#newcode1462
src/mips/lithium-codegen-mips.cc:1462: // Correct the sign of the result
is the constant is negative.
nit: first 'is' -> 'if'
https://codereview.chromium.org/25050002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
