LGTM if comments are addressed.
https://codereview.chromium.org/25732002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/25732002/diff/1/src/objects.cc#newcode510
src/objects.cc:510: Handle<Object>
JSObject::GetPropertyWithCallback(Handle<JSObject> holder,
nit: s/holder/object/ for consistency.
https://codereview.chromium.org/25732002/diff/1/src/objects.cc#newcode524
src/objects.cc:524: Handle<JSObject> failed_check_obj,
nit: s/failed_check_obj/object/ for consistency.
https://codereview.chromium.org/25732002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/25732002/diff/1/src/objects.h#newcode2120
src/objects.h:2120: static Handle<Object>
GetPropertyWithCallback(Handle<JSObject> holder,
nit: s/holder/object/ for consistency.
https://codereview.chromium.org/25732002/diff/1/src/objects.h#newcode2252
src/objects.h:2252: Handle<JSObject> failed_check_obj,
nit: s/failed_check_obj/object/ for consistency.
Also I think this should be made private and the Object class should be
made a friend of JSObject (similar to what we did with JSReceiver). This
will prevent this entry point from being abused from outside.
https://codereview.chromium.org/25732002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
