LGTM
Some style comments
https://codereview.chromium.org/24957003/diff/32001/tools/sodium/index.html
File tools/sodium/index.html (right):
https://codereview.chromium.org/24957003/diff/32001/tools/sodium/index.html#newcode8
tools/sodium/index.html:8: <script
src="https://google-code-prettify.googlecode.com/svn/loader/run_prettify.js";></script>
Are you sure you want to load it from there? It is an svn server hit.
https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js
File tools/sodium/sodium.js (right):
https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js#newcode366
tools/sodium/sodium.js:366: asmDivElement.innerHTML = '<div
id=\"asm-text\">' + newHtml + '</div>';
Use createElement here
https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js#newcode394
tools/sodium/sodium.js:394:
document.getElementById('log-file-id').addEventListener('change',
Consider replacing getElementById with parameters to Sodium, populated
from the caller
https://codereview.chromium.org/24957003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
