Reviewers: Yang,
Description:
Fix warnings
[email protected]
BUG=
Please review this at https://codereview.chromium.org/71373003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -11 lines):
M include/v8.h
M src/api.cc
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
6d97e191303ac4f9566759ece4d71843e6ac3fc7..f8ef7c1fc4b66cfc532f61505f150d01d9b60a86
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -329,6 +329,8 @@ template <class T> class Handle {
friend Handle<Boolean> False(Isolate* isolate);
friend class Context;
friend class HandleScope;
+ friend class Object;
+ friend class Private;
V8_INLINE static Handle<T> New(Isolate* isolate, T* that);
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
e55e0aa08570c0e57978a16e411f13faad0f38e0..65e73450239c352381676bedb560b332761ef3cd
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3192,8 +3192,8 @@ bool v8::Object::ForceSet(v8::Handle<Value> key,
bool v8::Object::SetPrivate(v8::Handle<Private> key, v8::Handle<Value>
value) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Set(*key_as_value, value, DontEnum);
+ return Set(v8::Handle<Value>(reinterpret_cast<Value*>(*key)),
+ value, DontEnum);
}
@@ -3249,8 +3249,7 @@ Local<Value> v8::Object::Get(uint32_t index) {
Local<Value> v8::Object::GetPrivate(v8::Handle<Private> key) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Get(*key_as_value);
+ return Get(v8::Handle<Value>(reinterpret_cast<Value*>(*key)));
}
@@ -3454,8 +3453,7 @@ bool v8::Object::Delete(v8::Handle<Value> key) {
bool v8::Object::DeletePrivate(v8::Handle<Private> key) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Delete(*key_as_value);
+ return Delete(v8::Handle<Value>(reinterpret_cast<Value*>(*key)));
}
@@ -3474,8 +3472,7 @@ bool v8::Object::Has(v8::Handle<Value> key) {
bool v8::Object::HasPrivate(v8::Handle<Private> key) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Has(*key_as_value);
+ return Has(v8::Handle<Value>(reinterpret_cast<Value*>(*key)));
}
@@ -6197,9 +6194,7 @@ Local<Private> v8::Private::New(
symbol->set_name(*name);
}
Local<Symbol> result = Utils::ToLocal(symbol);
- v8::Handle<Private>* result_as_private =
- reinterpret_cast<v8::Handle<Private>*>(&result);
- return *result_as_private;
+ return v8::Handle<Private>(reinterpret_cast<Private*>(*result));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
