LGTM once comments are addressed.
https://codereview.chromium.org/72813004/diff/30001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/72813004/diff/30001/src/arm/macro-assembler-arm.cc#newcode3405
src/arm/macro-assembler-arm.cc:3405: b(ne, &is_object);
Use ThrowIfNot(ne, kNonObject) instead?
Personally I would like ThrowIf better, for better readability (no
double negation). We do have a NegateCondition function for this
purpose.
https://codereview.chromium.org/72813004/diff/30001/src/arm/macro-assembler-arm.cc#newcode3819
src/arm/macro-assembler-arm.cc:3819: intptr_t p0 = (p1 & ~kSmiTagMask) +
kSmiTag;
How about just encoding the reason enum as smi and pass that to the
runtime?
https://codereview.chromium.org/72813004/diff/30001/test/mjsunit/fuzz-natives-part3.js
File test/mjsunit/fuzz-natives-part3.js (right):
https://codereview.chromium.org/72813004/diff/30001/test/mjsunit/fuzz-natives-part3.js#newcode119
test/mjsunit/fuzz-natives-part3.js:119: "ThrowMessage": true,
Please sync that to the other files named fuzz-natives-part{1,2,4}.js as
well.
https://codereview.chromium.org/72813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
