LGTM with a nit and a high-level comment:
"fast" is way too generic as a build target name. I'd suggest "quickcheck".
https://codereview.chromium.org/94703002/diff/20001/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/94703002/diff/20001/tools/run-tests.py#newcode205
tools/run-tests.py:205: # predefined arch_and_mode since it is more
expressive as arch and mode.
s/as/than/
https://codereview.chromium.org/94703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
