One round of comments. Looking good.
https://codereview.chromium.org/96783002/diff/110001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/96783002/diff/110001/src/heap.cc#newcode520
src/heap.cc:520: casted->dependent_code()->DeoptimizeDependentCodeGroup(
IMHO this should be done as part of DigestPretenuringFeedback() instead
of here. Also we need to deopt whenever the decision changes in either
way, not just when we switch from NOT_TENURED to TENURED I think.
https://codereview.chromium.org/96783002/diff/110001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/96783002/diff/110001/src/hydrogen.cc#newcode9349
src/hydrogen.cc:9349:
site_context->current()->AddDependentCompilationInfo(
IMHO both accesses here should be behind the
FLAG_allocation_site_pretenuring flag. If that flag is false, we should
either fall-back to the global mode or to NOT_TENURED I guess. WDYT?
Unless you are planning to remove that flag completely soon, then we
could just start dropping checks already.
https://codereview.chromium.org/96783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
