On 2013/12/04 09:52:56, Toon Verwaest wrote:
LGTM. The use of NONE64 is a bit odd given that Move (movp) will move a
NONE32
on x32. Should we introduce a NONEP perhaps? We can defer this to a
future CL
though.
We could introduce a static function in X64 Assembler.
static inline RelocInfo::Mode RelocInfoNone() {
if (kPointerSize == kInt64Size) {
return RelocInfo::NONE64;
} else {
ASSERT(kPointerSize == kInt32Size);
return RelocInfo::NONE32;
}
}
and replace RelocInfo::NONE64 with Assembler::RelocInfoNone(). I will submit
such a CL after committing this one.
https://codereview.chromium.org/64453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
