LGTM with 1 comment. Make sure to check performance though.
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc#newcode10868
src/objects.cc:10868: if (!needs_extended_extra_ic_state(kind())) {
I still argue "needs_extended_extra_ic_state" has nothing to do with
IsContextual.
Please just check for LOAD_IC/CALL_IC/STORE_IC. All of them can be
contextual. Nothing else can be.
https://codereview.chromium.org/96083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
