On 2013/12/04 17:49:16, titzer wrote:
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc#newcode8670
src/runtime.cc:8670: if (!unoptimized->contains(frame->pc())) {
I am not sure this is an improvement to no longer take the pc offset,
then do
a
stack walk just to check if it is the fast case. I think you should
instead
pass
the PC and then you can directly check if the unoptimized code contains
that
PC,
and only do a stack walk in the (unlikely) failure case.
Like discussed offline, passing the PC from builtin is not that simple,
since it
would not be GC safe if passed directly. I added a comment for that.
https://codereview.chromium.org/99013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
