Even though we aren't officially on the hook for MIPS, this change seems
sufficiently mechanical that we should go ahead and do it in this CL, I
think.
https://codereview.chromium.org/93803003/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/93803003/diff/1/src/ia32/lithium-ia32.cc#newcode1087
src/ia32/lithium-ia32.cc:1087: ZoneList<HValue*>*
objects_to_materialize, LEnvironment* result) {
AFAICT, this method is an exact duplicate on all the platforms. The only
thing is that it uses the UseAny method from the LChunkBuilder class,
which is a platform-specific class (i.e there is no platform-independent
definition of this class).
Would it be possible to factor this out into a platform-independent
method that takes functions to manipulate the platform-dependent
LChunkBuilder (e.g. AddUse, etc)?
That could be a real code savings.
https://codereview.chromium.org/93803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
