On 2014/01/09 07:36:15, Sven Panne wrote:
Actually, the cpu-profiler.cc part is wrong. :-/ SamplingCircularQueue, a
member
of ProfilerEventsProcessor, actually has a 64-byte alignment requirement,
so
VS2013 is correct. We have similar problems in test-cpu-profiler.cc, and
all
those problems are platform-independent, because no platform guarantees
such
an
alignment for new/malloc. Probably we're just lucky because
ProfilerEventsProcessor is so big that the underlying memory management
system
allocates new pages from the OS, anyway, having the required alignment.
I'll come up with a real fix...
To be fair, the problem with cpu-profiler.cc existed before this CL, it is
just
that VS2013 is kind enough to warn us that alignment is wrong.
Thanks for taking a deep look!
https://codereview.chromium.org/23449035/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
