Looks good from my side minus some nits below.
https://codereview.chromium.org/101413006/diff/400001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/101413006/diff/400001/src/arm/lithium-arm.cc#newcode2145
src/arm/lithium-arm.cc:2145:
!(IsDoubleOrFloatElementsKind(instr->elements_kind()))) ||
remove () around IsDouble...
https://codereview.chromium.org/101413006/diff/400001/src/arm/lithium-arm.cc#newcode2147
src/arm/lithium-arm.cc:2147:
(IsDoubleOrFloatElementsKind(instr->elements_kind()))));
Remove () around IsDouble...
https://codereview.chromium.org/101413006/diff/400001/src/arm/lithium-arm.cc#newcode2156
src/arm/lithium-arm.cc:2156: (elements_kind ==
EXTERNAL_UNSIGNED_INT_ELEMENTS) ||
remove ()
https://codereview.chromium.org/101413006/diff/400001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/101413006/diff/400001/src/arm/lithium-codegen-arm.cc#newcode3374
src/arm/lithium-codegen-arm.cc:3374: if (instr->is_external() ||
instr->is_fixed_typed_array()) {
Perhaps we should add a helper method that wraps is_external() ||
is_fixed_typed_array()? Seems like that's used often.
https://codereview.chromium.org/101413006/diff/400001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/101413006/diff/400001/src/objects-inl.h#newcode501
src/objects-inl.h:501: if (!Object::IsHeapObject())
Use { } if you put return false on a new line. Also ok as
if (!Object::IsHeapObject()) return false;
https://codereview.chromium.org/101413006/diff/400001/src/objects-inl.h#newcode2724
src/objects-inl.h:2724: HeapObject::cast(object)->map()->instance_type()
== on previous line
https://codereview.chromium.org/101413006/diff/400001/src/objects-visiting.cc
File src/objects-visiting.cc (right):
https://codereview.chromium.org/101413006/diff/400001/src/objects-visiting.cc#newcode85
src/objects-visiting.cc:85:
spurious line addition
https://codereview.chromium.org/101413006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
