Reviewers: m.m.capewell,

Description:
A64: Make 'debug BREAK' instructions halt on real hardware.

Please review this at https://codereview.chromium.org/146733004/

SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64

Affected files (+4, -0 lines):
  M src/a64/assembler-a64.cc


Index: src/a64/assembler-a64.cc
diff --git a/src/a64/assembler-a64.cc b/src/a64/assembler-a64.cc
index 4aee4182c1c84169883b19420e16f1c95540762b..08469444d97470ea847bb70a856652306ea98409 100644
--- a/src/a64/assembler-a64.cc
+++ b/src/a64/assembler-a64.cc
@@ -1808,6 +1808,10 @@ void Assembler::debug(const char* message, uint32_t code, Instr params) {
   ASSERT(SizeOfCodeGeneratedSince(&start) == kDebugMessageOffset);
   EmitStringData(message);
   hlt(kImmExceptionIsUnreachable);
+#else
+  if (params & BREAK) {
+    hlt(kImmExceptionIsDebug);
+  }
 #endif
 }



--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to