Reviewers: Benedikt Meurer,
Description:
Remove unused AllocationSpace paramenter from CollectGarbage.
BUG=
Please review this at https://codereview.chromium.org/148943004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -6 lines):
M src/heap-inl.h
M src/heap.h
M src/heap.cc
Index: src/heap-inl.h
diff --git a/src/heap-inl.h b/src/heap-inl.h
index
f28b82c732a71088b46dcb9e93f4e85c470ec78f..d42e1cfc1164f396fe0b782d93754ef8f3510e42
100644
--- a/src/heap-inl.h
+++ b/src/heap-inl.h
@@ -555,8 +555,7 @@ bool Heap::CollectGarbage(AllocationSpace space,
const v8::GCCallbackFlags callbackFlags) {
const char* collector_reason = NULL;
GarbageCollector collector = SelectGarbageCollector(space,
&collector_reason);
- return CollectGarbage(
- space, collector, gc_reason, collector_reason, callbackFlags);
+ return CollectGarbage(collector, gc_reason, collector_reason,
callbackFlags);
}
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
a6db39c58cde422c7536d22c2dab95a232a75f9e..4eadabefe5c949b60643fee2bf5001e9637735db
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -739,7 +739,7 @@ void Heap::CollectAllAvailableGarbage(const char*
gc_reason) {
const int kMaxNumberOfAttempts = 7;
const int kMinNumberOfAttempts = 2;
for (int attempt = 0; attempt < kMaxNumberOfAttempts; attempt++) {
- if (!CollectGarbage(OLD_POINTER_SPACE, MARK_COMPACTOR, gc_reason,
NULL) &&
+ if (!CollectGarbage(MARK_COMPACTOR, gc_reason, NULL) &&
attempt + 1 >= kMinNumberOfAttempts) {
break;
}
@@ -751,8 +751,7 @@ void Heap::CollectAllAvailableGarbage(const char*
gc_reason) {
}
-bool Heap::CollectGarbage(AllocationSpace space,
- GarbageCollector collector,
+bool Heap::CollectGarbage(GarbageCollector collector,
const char* gc_reason,
const char* collector_reason,
const v8::GCCallbackFlags gc_callback_flags) {
Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index
fae21176617e17780d17857ce751e3f8467ae939..011ffd5e68b0179f4b524e8db227dbc952fe06b9
100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -2123,7 +2123,6 @@ class Heap {
// Returns whether there is a chance that another major GC could
// collect more garbage.
bool CollectGarbage(
- AllocationSpace space,
GarbageCollector collector,
const char* gc_reason,
const char* collector_reason,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
