all done. note that in order to fix a few tests, I needed to add a
HandleScope
in runtime.cc and to exempt %RunMicrotasks in fuzz-natives-part3.js. I'm
https://codereview.chromium.org/131413008/diff/80001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/131413008/diff/80001/src/promise.js#newcode185
src/promise.js:185: function HandlePromise(value, handler, deferred) {
On 2014/02/04 13:50:08, rossberg wrote:
Nit: call this PromiseHandle for consistency
Done.
https://codereview.chromium.org/131413008/diff/80001/test/cctest/test-microtask-delivery.cc
File test/cctest/test-microtask-delivery.cc (right):
https://codereview.chromium.org/131413008/diff/80001/test/cctest/test-microtask-delivery.cc#newcode65
test/cctest/test-microtask-delivery.cc:65: "function handler(resolve) {
resolver.resolve = resolve; }"
On 2014/02/04 13:50:08, rossberg wrote:
Nit: any reason why you don't just use "resolver = resolve"?
Done.
https://codereview.chromium.org/131413008/diff/80001/test/mjsunit/harmony/microtask-delivery.js
File test/mjsunit/harmony/microtask-delivery.js (right):
https://codereview.chromium.org/131413008/diff/80001/test/mjsunit/harmony/microtask-delivery.js#newcode122
test/mjsunit/harmony/microtask-delivery.js:122: assertOrdering(['p1',
'o1', 'o2', 'p2', 'o1', 'o3', 'p3']);
Yeah. I know. My hope is that most developers won't ever have to care
about delivery order. For sure, those that do will be sad. If you have
ideas about how to improve this, don't be shy.
On 2014/02/04 13:50:08, rossberg wrote:
Whew, I had to stare at this for 10 minutes to figure out why this is
the
expected outcome. I fear we are in for a major WTF from programmers
with this
semantics...
https://codereview.chromium.org/131413008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
