https://codereview.chromium.org/141653009/diff/80001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/141653009/diff/80001/src/hydrogen-check-elimination.cc#newcode189
src/hydrogen-check-elimination.cc:189: HCheckTable* Merge(HBasicBlock*
succ, HCheckTable* that,
On 2014/02/05 11:47:46, titzer wrote:
On 2014/02/04 13:12:26, titzer wrote:
> We should rename "that" to be "pred", to be more clear.
To be clearer:
"that_block" to "pred_block"
Done.
https://codereview.chromium.org/141653009/diff/110001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/141653009/diff/110001/src/hydrogen-check-elimination.cc#newcode53
src/hydrogen-check-elimination.cc:53: bool remove_at_compation_;
On 2014/02/05 11:47:46, titzer wrote:
I don't think we need this; see below
Done.
https://codereview.chromium.org/141653009/diff/110001/src/hydrogen-check-elimination.cc#newcode148
src/hydrogen-check-elimination.cc:148: copy->Insert(phi, NULL,
pred_entry->maps_);
On 2014/02/05 11:47:46, titzer wrote:
I think you want to make a copy of pred_entry->maps_, since these sets
are
mutable and the new entry for the phi would alias the maps for the
entry that
was just found.
Done.
https://codereview.chromium.org/141653009/diff/110001/src/hydrogen-check-elimination.cc#newcode222
src/hydrogen-check-elimination.cc:222: continue;
On 2014/02/05 11:47:46, titzer wrote:
I think in this case you can just immediately process the phi. Look up
the
corresponding phi input from pred and union into the entry for this
phi. If
there is no entry for the corresponding phi input, kill this entry.
Thus you need only one pass through this table and don't need to
iterate over
succ's phi list.
Done.
https://codereview.chromium.org/141653009/diff/110001/src/hydrogen-check-elimination.cc#newcode526
src/hydrogen-check-elimination.cc:526: if (entry->object_ == NULL)
continue;
On 2014/02/05 11:47:46, titzer wrote:
Why did this invariant change?
Done.
https://codereview.chromium.org/141653009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
