Revision: 19178
Author: [email protected]
Date: Fri Feb 7 07:06:13 2014 UTC
Log: Make LeakSanitizer happy, part 2. Fixed register usage on the way.
Note that according to the System V ABI for AMD64, rbx must be
preserved across calls. We actually crash with clang in the x64
assembler tests without that fix, we were lucky with GCC.
[email protected]
Review URL: https://codereview.chromium.org/144313017
http://code.google.com/p/v8/source/detail?r=19178
Modified:
/branches/bleeding_edge/test/cctest/test-assembler-x64.cc
/branches/bleeding_edge/test/cctest/test-global-handles.cc
/branches/bleeding_edge/test/cctest/test-heap.cc
=======================================
--- /branches/bleeding_edge/test/cctest/test-assembler-x64.cc Wed Jan 8
06:53:31 2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-assembler-x64.cc Fri Feb 7
07:06:13 2014 UTC
@@ -179,10 +179,10 @@
Assembler assm(CcTest::i_isolate(), buffer,
static_cast<int>(actual_size));
__ movq(rax, Operand(arg1, 0));
- __ movq(rbx, Operand(arg2, 0));
- __ xchgl(rax, rbx);
+ __ movq(rdx, Operand(arg2, 0));
+ __ xchgl(rax, rdx);
__ movq(Operand(arg1, 0), rax);
- __ movq(Operand(arg2, 0), rbx);
+ __ movq(Operand(arg2, 0), rdx);
__ ret(0);
CodeDesc desc;
@@ -279,8 +279,8 @@
// Set rax with the ZF flag of the testl instruction.
Label done;
__ movq(rax, Immediate(1));
- __ movq(rbx, Operand(arg2, 0));
- __ testl(Operand(arg1, 0), rbx);
+ __ movq(rdx, Operand(arg2, 0));
+ __ testl(Operand(arg1, 0), rdx);
__ j(zero, &done, Label::kNear);
__ movq(rax, Immediate(0));
__ bind(&done);
=======================================
--- /branches/bleeding_edge/test/cctest/test-global-handles.cc Fri Jan 3
14:31:17 2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-global-handles.cc Fri Feb 7
07:06:13 2014 UTC
@@ -316,6 +316,8 @@
reinterpret_cast<HeapObject**>(g2s1.location()));
ASSERT(implicit_refs->at(1)->length == 1);
ASSERT(implicit_refs->at(1)->children[0] == g2c1.location());
+ global_handles->RemoveObjectGroups();
+ global_handles->RemoveImplicitRefGroups();
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Fri Jan 31 16:52:17
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-heap.cc Fri Feb 7 07:06:13
2014 UTC
@@ -3483,7 +3483,7 @@
DeferredHandleScope deferred(isolate);
DummyVisitor visitor;
isolate->handle_scope_implementer()->Iterate(&visitor);
- deferred.Detach();
+ delete deferred.Detach();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
