Reviewers: Sven Panne,
Message:
Wrong upper limit in for loops... PTAL
Description:
Fix printing of GVN flags.
Please review this at https://codereview.chromium.org/142253003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -8 lines):
M src/hydrogen-gvn.cc
M src/hydrogen-instructions.h
Index: src/hydrogen-gvn.cc
diff --git a/src/hydrogen-gvn.cc b/src/hydrogen-gvn.cc
index
daca593b39908ff899e84587506e8e05d4bce392..e491ef5b98cb9c0424d5502a84c79174587425cd
100644
--- a/src/hydrogen-gvn.cc
+++ b/src/hydrogen-gvn.cc
@@ -439,7 +439,7 @@ void
HGlobalValueNumberingPhase::ComputeBlockSideEffects() {
SmartArrayPointer<char> GetGVNFlagsString(GVNFlagSet flags) {
- char underlying_buffer[kLastFlag * 128];
+ char underlying_buffer[kNumberOfFlags * 128];
Vector<char> buffer(underlying_buffer, sizeof(underlying_buffer));
#if DEBUG
int offset = 0;
@@ -448,7 +448,7 @@ SmartArrayPointer<char> GetGVNFlagsString(GVNFlagSet
flags) {
buffer[0] = 0;
uint32_t set_depends_on = 0;
uint32_t set_changes = 0;
- for (int bit = 0; bit < kLastFlag; ++bit) {
+ for (int bit = 0; bit < kNumberOfFlags; ++bit) {
if (flags.Contains(static_cast<GVNFlag>(bit))) {
if (bit % 2 == 0) {
set_changes++;
@@ -457,15 +457,15 @@ SmartArrayPointer<char> GetGVNFlagsString(GVNFlagSet
flags) {
}
}
}
- bool positive_changes = set_changes < (kLastFlag / 2);
- bool positive_depends_on = set_depends_on < (kLastFlag / 2);
+ bool positive_changes = set_changes < (kNumberOfFlags / 2);
+ bool positive_depends_on = set_depends_on < (kNumberOfFlags / 2);
if (set_changes > 0) {
if (positive_changes) {
offset += OS::SNPrintF(buffer + offset, "changes [");
} else {
offset += OS::SNPrintF(buffer + offset, "changes all except [");
}
- for (int bit = 0; bit < kLastFlag; ++bit) {
+ for (int bit = 0; bit < kNumberOfFlags; ++bit) {
if (flags.Contains(static_cast<GVNFlag>(bit)) == positive_changes) {
switch (static_cast<GVNFlag>(bit)) {
#define DECLARE_FLAG(type) \
@@ -494,7 +494,7 @@ GVN_UNTRACKED_FLAG_LIST(DECLARE_FLAG)
} else {
offset += OS::SNPrintF(buffer + offset, "depends on all except [");
}
- for (int bit = 0; bit < kLastFlag; ++bit) {
+ for (int bit = 0; bit < kNumberOfFlags; ++bit) {
if (flags.Contains(static_cast<GVNFlag>(bit)) ==
positive_depends_on) {
switch (static_cast<GVNFlag>(bit)) {
#define DECLARE_FLAG(type) \
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
73348a6616828977432b128183487ad546baaff4..b29b581bd3cd1a50fb4c5b71494afe5d2ea2354c
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -482,8 +482,7 @@ enum GVNFlag {
GVN_TRACKED_FLAG_LIST(DECLARE_FLAG)
GVN_UNTRACKED_FLAG_LIST(DECLARE_FLAG)
#undef DECLARE_FLAG
- kAfterLastFlag,
- kLastFlag = kAfterLastFlag - 1,
+ kNumberOfFlags,
#define COUNT_FLAG(type) + 1
kNumberOfTrackedSideEffects = 0 GVN_TRACKED_FLAG_LIST(COUNT_FLAG)
#undef COUNT_FLAG
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
