On 2014/02/07 10:02:38, Michael Starzinger wrote:
https://codereview.chromium.org/146983007/diff/1/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/146983007/diff/1/src/scanner.h#newcode143
src/scanner.h:143: return kIsWhiteSpace.get(c) || c == 0xFEFF;
This is kind of brittle! Can we please move this special casing into a
char-predicate (e.g struct WhiteSpace) and use that predicate in the cache
instead of special-casing after the cache lookup?
https://codereview.chromium.org/146983007/diff/1/test/mjsunit/whitespaces.js
File test/mjsunit/whitespaces.js (right):
https://codereview.chromium.org/146983007/diff/1/test/mjsunit/whitespaces.js#newcode1
test/mjsunit/whitespaces.js:1: // Copyright 2012 the V8 project authors.
All
rights reserved.
nit: 2014
Addressed comments. Had to fix an outdated third-party test.
https://codereview.chromium.org/146983007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
