Revision: 19210
Author: [email protected]
Date: Sat Feb 8 02:16:25 2014 UTC
Log: Revert "Introduce MoveDouble to the X64 MacroAssembler" (r17383)
The direction is to use "movl, movq, movp" instead of introducing new
Macro assembler instructions.
[email protected]
Review URL: https://codereview.chromium.org/101083002
http://code.google.com/p/v8/source/detail?r=19210
Modified:
/branches/bleeding_edge/src/x64/codegen-x64.cc
/branches/bleeding_edge/src/x64/lithium-codegen-x64.cc
/branches/bleeding_edge/src/x64/macro-assembler-x64.h
=======================================
--- /branches/bleeding_edge/src/x64/codegen-x64.cc Fri Jan 24 01:59:00 2014
UTC
+++ /branches/bleeding_edge/src/x64/codegen-x64.cc Sat Feb 8 02:16:25 2014
UTC
@@ -422,7 +422,7 @@
// Non-hole double, copy value into a heap number.
__ AllocateHeapNumber(rax, r15, &gc_required);
// rax: new heap number
- __ MoveDouble(FieldOperand(rax, HeapNumber::kValueOffset), r14);
+ __ movq(FieldOperand(rax, HeapNumber::kValueOffset), r14);
__ movp(FieldOperand(r11,
r9,
times_pointer_size,
=======================================
--- /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc Fri Jan 31
16:52:17 2014 UTC
+++ /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc Sat Feb 8
02:16:25 2014 UTC
@@ -3417,10 +3417,10 @@
__ LoadFromSafepointRegisterSlot(input_reg, input_reg);
__ bind(&allocated);
- __ MoveDouble(tmp2, FieldOperand(input_reg, HeapNumber::kValueOffset));
+ __ movq(tmp2, FieldOperand(input_reg, HeapNumber::kValueOffset));
__ shl(tmp2, Immediate(1));
__ shr(tmp2, Immediate(1));
- __ MoveDouble(FieldOperand(tmp, HeapNumber::kValueOffset), tmp2);
+ __ movq(FieldOperand(tmp, HeapNumber::kValueOffset), tmp2);
__ StoreToSafepointRegisterSlot(input_reg, tmp);
__ bind(&done);
=======================================
--- /branches/bleeding_edge/src/x64/macro-assembler-x64.h Mon Jan 27
09:57:54 2014 UTC
+++ /branches/bleeding_edge/src/x64/macro-assembler-x64.h Sat Feb 8
02:16:25 2014 UTC
@@ -841,9 +841,6 @@
void Pop(Register dst) { pop(dst); }
void PushReturnAddressFrom(Register src) { push(src); }
void PopReturnAddressTo(Register dst) { pop(dst); }
- void MoveDouble(Register dst, const Operand& src) { movq(dst, src); }
- void MoveDouble(const Operand& dst, Register src) { movq(dst, src); }
-
void Move(Register dst, ExternalReference ext) {
movp(dst, reinterpret_cast<Address>(ext.address()),
RelocInfo::EXTERNAL_REFERENCE);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
