Reviewers: Benedikt Meurer,
Message:
Hi Benedikt, PTAL, thx!
--Michael
Description:
Fix gcstress test failure
Map collection complicates a test that wants to assert on code opt/deopt
because of prototype-chain changes. It can happen that a gc occurs
in the stack guard at the start of optimized function foo that deopts
function foo because of a map being collected and deoptimizing it's
dependent code.
Please review this at https://codereview.chromium.org/159653002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -0 lines):
M test/mjsunit/getters-on-elements.js
Index: test/mjsunit/getters-on-elements.js
diff --git a/test/mjsunit/getters-on-elements.js
b/test/mjsunit/getters-on-elements.js
index
55fc86b8408fc97ded5b279f3f2ecade986b9269..3bc360f14377e3443699a56d55a523c84f141a99
100644
--- a/test/mjsunit/getters-on-elements.js
+++ b/test/mjsunit/getters-on-elements.js
@@ -26,10 +26,17 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --allow-natives-syntax --max-opt-count=100 --noalways-opt
+// Flags: --nocollect-maps
// We specify max-opt-count because we opt/deopt the same function many
// times.
+// We specify nocollect-maps because in gcstress we can end up deoptimizing
+// a function in a gc in the stack guard at the beginning of the
(optimized)
+// function due to leftover map clearing work that results in deoptimizing
+// dependent code from those maps. The choice is to insert strategic gc()
+// calls or specify this flag.
+
// It's nice to run this in other browsers too.
var standalone = false;
if (standalone) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
