Revision: 19258
Author: [email protected]
Date: Tue Feb 11 09:06:13 2014 UTC
Log: Fix gcstress test failure
Map collection complicates a test that wants to assert on code opt/deopt
because of prototype-chain changes. It can happen that a gc occurs
in the stack guard at the start of optimized function foo that deopts
function foo because of a map being collected and deoptimizing it's
dependent code.
[email protected]
Review URL: https://codereview.chromium.org/159653002
http://code.google.com/p/v8/source/detail?r=19258
Modified:
/branches/bleeding_edge/test/mjsunit/getters-on-elements.js
=======================================
--- /branches/bleeding_edge/test/mjsunit/getters-on-elements.js Wed Nov 6
15:45:43 2013 UTC
+++ /branches/bleeding_edge/test/mjsunit/getters-on-elements.js Tue Feb 11
09:06:13 2014 UTC
@@ -26,10 +26,17 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --allow-natives-syntax --max-opt-count=100 --noalways-opt
+// Flags: --nocollect-maps
// We specify max-opt-count because we opt/deopt the same function many
// times.
+// We specify nocollect-maps because in gcstress we can end up deoptimizing
+// a function in a gc in the stack guard at the beginning of the
(optimized)
+// function due to leftover map clearing work that results in deoptimizing
+// dependent code from those maps. The choice is to insert strategic gc()
+// calls or specify this flag.
+
// It's nice to run this in other browsers too.
var standalone = false;
if (standalone) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
