Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r19265 (presubmit successful).
Description:
Traitify ParserBase and move functions there.
(Second try, with fixes. First try:
https://codereview.chromium.org/149913006/ )
The long-term goal is to move all recursive descent functions from Parser
and
PreParser into ParserBase, but first they need to be unified.
Notes:
- The functions moved in this CL: ParseIdentifier, ParseIdentifierName,
ParseIdentifierNameOrGetOrSet, ParseIdentifierOrStrictReservedWord.
- IOW, this CL removes Parser::ParseIdentifier and
PreParser::ParseIdentifier
and adds ParserBase::ParseIdentifier, etc.
- Error reporting used to require virtual funcs; now error reporting is
moved to
the Traits too, and ParserBase no longer needs to be virtual.
- I had to move PreParser::Identifier out of the PreParser class, because
otherwise PreParserTraits cannot use it in a typedef.
BUG=v8:3126
LOG=N
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19265
Please review this at https://codereview.chromium.org/158913003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+643, -673 lines):
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
