LGTM. Just nits about the naming.
https://codereview.chromium.org/166023003/diff/30001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/166023003/diff/30001/src/heap.h#newcode203
src/heap.h:203: #define ROOT_SMI_LIST(V)
\
nit: Can we call it SMI_ROOT_LIST instead?
https://codereview.chromium.org/166023003/diff/30001/src/heap.h#newcode1356
src/heap.h:1356: void IterateRootSmis(ObjectVisitor* v);
nit: Likewise IterateSmiRoots() here.
https://codereview.chromium.org/166023003/diff/30001/src/heap.h#newcode1593
src/heap.h:1593: #define ROOT_INDEX_DECLARATION(type, name, camel_name)
k##camel_name##RootIndex,
nit: Can we move the #define and #undef pragmas into the struct again? I
actually find the previous formatting much easier to read than the new
one.
https://codereview.chromium.org/166023003/diff/30001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/166023003/diff/30001/src/objects.h#newcode10645
src/objects.h:10645: V(kRootSmisList, "root_smis_list", "(Root smis)")
\
nit: Likewise kSmiRootList and smi_root_list here.
https://codereview.chromium.org/166023003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
