On 2014/02/17 15:26:36, Dmitry Lomov (chromium) wrote:

https://codereview.chromium.org/166993002/diff/70001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):


https://codereview.chromium.org/166993002/diff/70001/test/cctest/test-heap-profiler.cc#newcode2406
test/cctest/test-heap-profiler.cc:2406: TEST(ArrayBufferSharedBackingStore) {
I'd prefer a test that allocates ArrayBuffers with shared backing store
through
the API, and does not rely on SinTable implementation.

What do you think?

Agree. I'll try that.

https://codereview.chromium.org/166993002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to