Reviewers: Jakob,
Description:
Merged r19500 into 3.24 branch.
MIPS: Fix performance regression on sunspider string-unpack-code.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/167973007/
SVN Base: https://v8.googlecode.com/svn/branches/3.24
Affected files (+8, -4 lines):
M src/mips/stub-cache-mips.cc
M src/version.cc
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index
60ab0b8704e047c85a92e04b63d336f5a5e2b13d..d1b428a34560d41a0d7c55f96e383423c26b4fdf
100644
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -1487,10 +1487,11 @@ Handle<Code>
BaseLoadStoreStubCompiler::CompilePolymorphicIC(
}
Label number_case;
+ Register match = scratch1();
Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
- __ JumpIfSmi(receiver(), smi_target);
+ __ JumpIfSmi(receiver(), smi_target, match); // Reg match is 0 if Smi.
- Register map_reg = scratch1();
+ Register map_reg = scratch2();
int receiver_count = types->length();
int number_of_handled_maps = 0;
@@ -1500,12 +1501,15 @@ Handle<Code>
BaseLoadStoreStubCompiler::CompilePolymorphicIC(
Handle<Map> map = IC::TypeToMap(*type, isolate());
if (!map->is_deprecated()) {
number_of_handled_maps++;
+ // Check map and tail call if there's a match.
+ // Separate compare from branch, to provide path for above
JumpIfSmi().
+ __ Subu(match, map_reg, Operand(map));
if (type->Is(HeapType::Number())) {
ASSERT(!number_case.is_unused());
__ bind(&number_case);
}
__ Jump(handlers->at(current), RelocInfo::CODE_TARGET,
- eq, map_reg, Operand(map));
+ eq, match, Operand(zero_reg));
}
}
ASSERT(number_of_handled_maps != 0);
Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index
aa922ace93c03c3098187ce2dd5bfd0f87b070dc..b7f591e3f25f52aa5d6a9c8abd3998936cf29cd4
100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 3
#define MINOR_VERSION 24
#define BUILD_NUMBER 35
-#define PATCH_LEVEL 0
+#define PATCH_LEVEL 1
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
#define IS_CANDIDATE_VERSION 0
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
