Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Don't turn objects with empty-string properties into fast-mode.
Please review this at https://codereview.chromium.org/165743003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -5 lines):
M src/objects.cc
A + test/mjsunit/regress/regress-fast-empty-string.js
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
7360172e5b5d6a1036cd5af55e016b2dbb8a6567..e459332c76b47fd4b4d353d76655e7bfd5a2ddd7
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -15710,6 +15710,7 @@ MaybeObject*
NameDictionary::TransformPropertiesToFastFor(
// instance descriptor.
MaybeObject* maybe_key = heap->InternalizeString(String::cast(k));
if (!maybe_key->To(&key)) return maybe_key;
+ if (key->Equals(heap->empty_string())) return this;
}
PropertyDetails details = DetailsAt(i);
Index: test/mjsunit/regress/regress-fast-empty-string.js
diff --git a/test/mjsunit/regress/regress-3159.js
b/test/mjsunit/regress/regress-fast-empty-string.js
similarity index 50%
copy from test/mjsunit/regress/regress-3159.js
copy to test/mjsunit/regress/regress-fast-empty-string.js
index
cfc8a39b8d011533ed94fcaf11669814c9cbc4d2..9b9fea963a4f7f094283ce5b42289127cb7f594d
100644
--- a/test/mjsunit/regress/regress-3159.js
+++ b/test/mjsunit/regress/regress-fast-empty-string.js
@@ -2,9 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-try {
- new Uint32Array(new ArrayBuffer(1), 2, 3);
-} catch (e) {
- assertEquals("start offset of Uint32Array should be a multiple of 4",
- e.message);
+var o = {};
+o[""] = 1;
+var x = {__proto__:o};
+for (i = 0; i < 3; i++) {
+ o[""];
+}
+for (i = 0; i < 3; i++) {
+ assertEquals(undefined, o.x);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
