Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r19545 (tree was closed).
Description:
Mark HCompareMap as having Tagged representation
BUG=chromium:346636
LOG=y
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19545
Please review this at https://codereview.chromium.org/176923013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+32, -0 lines):
M src/hydrogen-instructions.h
A test/mjsunit/regress/regress-crbug-346636.js
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
0a92a9f4234b2a87e612c6fbd0cfcd4a787f3c97..baf64fcc32bb7ac7bbc6ffb44b03340add985fee
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -1617,6 +1617,7 @@ class HCompareMap V8_FINAL : public
HUnaryControlInstruction {
map->AddDependentCompilationInfo(
DependentCode::kPrototypeCheckGroup, info);
}
+ set_representation(Representation::Tagged());
}
int known_successor_index_;
Index: test/mjsunit/regress/regress-crbug-346636.js
diff --git a/test/mjsunit/regress/regress-crbug-346636.js
b/test/mjsunit/regress/regress-crbug-346636.js
new file mode 100644
index
0000000000000000000000000000000000000000..247f8be48223a1323090d3794c946c9cf2562c55
--- /dev/null
+++ b/test/mjsunit/regress/regress-crbug-346636.js
@@ -0,0 +1,31 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function assertSame(expected, found) {
+ if (found === expected) {
+ if (expected !== 0 || (1 / expected) == (1 / found)) return;
+ }
+ return;
+};
+
+function foo(x) {
+ return x.bar;
+}
+
+function getter1() {
+ assertSame(this, this);
+}
+var o1 = Object.defineProperty({}, "bar", { get: getter1 });
+foo(o1);
+foo(o1);
+
+function getter2() {
+ assertSame(this, this);
+}
+var o2 = Object.defineProperty({}, "bar", { get: getter2 });
+foo(o2);
+%OptimizeFunctionOnNextCall(foo);
+foo(o2);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
