lgtm
https://codereview.chromium.org/181553002/diff/1/src/lithium.h
File src/lithium.h (right):
https://codereview.chromium.org/181553002/diff/1/src/lithium.h#newcode74
src/lithium.h:74: if (kind == REGISTER) ASSERT(index >= 0);
nit: I have a weak preference for:
ASSERT(kind != REGISTER || index >= 0);
to make it immediately obvious to human readers that the entire line
doesn't do anything in Release mode.
https://codereview.chromium.org/181553002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
