Revision: 19599
Author: [email protected]
Date: Fri Feb 28 11:07:10 2014 UTC
Log: Fix representation generalization for doubles.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/184393002
http://code.google.com/p/v8/source/detail?r=19599
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-347909.js
Modified:
/branches/bleeding_edge/src/property-details.h
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-347909.js Fri Feb
28 11:07:10 2014 UTC
@@ -0,0 +1,19 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+var a = {y:1.5};
+a.y = 0;
+var b = a.y;
+a.y = {};
+var d = 1;
+function f() {
+ d = 0;
+ return {y: b};
+}
+f();
+f();
+%OptimizeFunctionOnNextCall(f);
+f();
=======================================
--- /branches/bleeding_edge/src/property-details.h Tue Feb 18 11:30:51 2014
UTC
+++ /branches/bleeding_edge/src/property-details.h Fri Feb 28 11:07:10 2014
UTC
@@ -138,7 +138,7 @@
ASSERT(kind_ != kExternal);
ASSERT(other.kind_ != kExternal);
- if (IsHeapObject()) return other.IsDouble() || other.IsNone();
+ if (IsHeapObject()) return other.IsNone();
if (kind_ == kUInteger8 && other.kind_ == kInteger8) return false;
if (kind_ == kUInteger16 && other.kind_ == kInteger16) return false;
return kind_ > other.kind_;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
