Reviewers: danno,
Description:
Merged r19535 into 3.23 branch.
Fix for a smi stores optimization on x64 with a regression test.
BUG=345715
LOG=N
[email protected]
Please review this at https://codereview.chromium.org/184553003/
SVN Base: https://v8.googlecode.com/svn/branches/3.23
Affected files (+27, -1 lines):
M src/version.cc
A test/mjsunit/regress/regress-crbug-345715.js
Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index
4bda0b000a6e36d6128b8785a2a03478a004de42..08ae1744fdfddc25b263cdab84ba265349c5f902
100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 3
#define MINOR_VERSION 23
#define BUILD_NUMBER 17
-#define PATCH_LEVEL 17
+#define PATCH_LEVEL 18
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
#define IS_CANDIDATE_VERSION 0
Index: test/mjsunit/regress/regress-crbug-345715.js
diff --git a/test/mjsunit/regress/regress-crbug-345715.js
b/test/mjsunit/regress/regress-crbug-345715.js
new file mode 100644
index
0000000000000000000000000000000000000000..a3753417dfb6f8440ec36f883dc6ac1be4a6c8ce
--- /dev/null
+++ b/test/mjsunit/regress/regress-crbug-345715.js
@@ -0,0 +1,26 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+a = {y:1.5};
+a.y = 0;
+b = a.y;
+c = {y:{}};
+
+function f() {
+ return 1;
+}
+
+function g() {
+ var e = {y: b};
+ var d = {x:f()};
+ var d = {x:f()};
+ return [e, d];
+}
+
+g();
+g();
+%OptimizeFunctionOnNextCall(g);
+assertEquals(1, g()[1].x);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
