https://codereview.chromium.org/183553003/diff/1/src/store-buffer.cc
File src/store-buffer.cc (right):
https://codereview.chromium.org/183553003/diff/1/src/store-buffer.cc#newcode534
src/store-buffer.cc:534: if (o == constant_pool_array_map) {
On 2014/03/03 13:56:13, Hannes Payer wrote:
I don't think a constant pool can contain old-to-new references,
right? In that
case you could just skip the constant pool right away.
You are right, skipping it entirely probably simpler. The one thing I
was considering was that this is called from VerifyPointers, so we might
want to ensure that we hadn't accidentally added new-space pointers into
a ConstantPoolArray, but since VerifyPointers only has a dummy
ObjectSlotCallback this probably isn't worth while anyway.
I've uploaded a change to just skip constant pool arrays.
https://codereview.chromium.org/183553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
