Followup is at https://codereview.chromium.org/178193028/ from here on. I
addressed your comment in that CL.
https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc
File src/ia32/disasm-ia32.cc (right):
https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newcode410
src/ia32/disasm-ia32.cc:410: AppendToBuffer("[%s*%d+0x%x]",
On 2014/03/04 13:43:35, titzer wrote:
Here too!
Done.
https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newcode440
src/ia32/disasm-ia32.cc:440: AppendToBuffer("[%s+0x%x]",
(this->*register_name)(rm), disp);
On 2014/03/04 13:43:35, titzer wrote:
Here too!
Done.
https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newcode442
src/ia32/disasm-ia32.cc:442: AppendToBuffer("[%s+%s*%d+0x%x]",
On 2014/03/04 13:43:35, titzer wrote:
Here too!
Done.
https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newcode457
src/ia32/disasm-ia32.cc:457: disp < 0 ? -disp : disp);
On 2014/03/04 13:43:35, titzer wrote:
I think you want a subroutine for adding the displacement?
And x64! :/
Done for x64. No subroutine though, I think that's less readable.
https://codereview.chromium.org/176993004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
