Looking good. Almost there.
https://codereview.chromium.org/186163002/diff/120001/src/v8.cc
File src/v8.cc (right):
https://codereview.chromium.org/186163002/diff/120001/src/v8.cc#newcode54
src/v8.cc:54: static void empty_log_internal_events(const char* name,
int se) { return; }
I think we can remove that return statement too. just an empty { }
should be fine.
https://codereview.chromium.org/186163002/diff/120001/src/v8.cc#newcode93
src/v8.cc:93: }
I think this should be put into Isolate::Init. And I think the callbacks
should be moved to log.h.
https://codereview.chromium.org/186163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
