Looking good, I like it!
Additionally, could you please add a comment to the corresponding API calls
explaining that the callbacks are not re-entrant.
https://codereview.chromium.org/177243012/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/177243012/diff/40001/test/cctest/test-api.cc#newcode18642
test/cctest/test-api.cc:18642: ASSERT(!obj.IsEmpty());
Can we call
CcTest::heap()->CollectAllGarbage(i::Heap::Heap::kAbortIncrementalMarkingMask);
at the end of this function, just to make sure that GC happens.
https://codereview.chromium.org/177243012/diff/40001/test/cctest/test-api.cc#newcode18659
test/cctest/test-api.cc:18659: ASSERT(!obj.IsEmpty());
Can we call
CcTest::heap()->CollectAllGarbage(i::Heap::Heap::kAbortIncrementalMarkingMask);
at the end of this function, just to make sure that GC happens.
https://codereview.chromium.org/177243012/diff/40001/test/cctest/test-api.cc#newcode18734
test/cctest/test-api.cc:18734:
CcTest::heap()->CollectAllGarbage(i::Heap::kNoGCFlags);
CcTest::heap()->CollectAllGarbage(i::Heap::Heap::kAbortIncrementalMarkingMask);
to make sure that GC gets triggerd if incremental marking is in
progress. This may happen on the stress gc builders.
https://codereview.chromium.org/177243012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
