https://codereview.chromium.org/190763012/diff/20001/src/a64/builtins-a64.cc
File src/a64/builtins-a64.cc (right):
https://codereview.chromium.org/190763012/diff/20001/src/a64/builtins-a64.cc#newcode456
src/a64/builtins-a64.cc:456: Register obj_end = x5;
Maybe set first_prop = NoReg to show that it is not used anymore? The
same for prop_fields below.
https://codereview.chromium.org/190763012/diff/20001/src/a64/builtins-a64.cc#newcode483
src/a64/builtins-a64.cc:483: __ Ldrb(x3, FieldMemOperand(init_map,
Map::kUnusedPropertyFieldsOffset));
x3 => element_count, here and below.
https://codereview.chromium.org/190763012/diff/20001/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/190763012/diff/20001/src/a64/macro-assembler-a64.cc#newcode2479
src/a64/macro-assembler-a64.cc:2479: Sub(field_ptr, dst,
Operand(field_ptr, LSL, kPointerSizeLog2));
I am convinced that this implementation is correct.
Any reason why you didn't choose the algorithm that is used in other
places?
In pseudocode:
counter = field_count - 2;
while (counter >= 0) {
store pair of fillers;
counter -= 2;
}
if (counter & 1) {
store one remaining filler;
}
https://codereview.chromium.org/190763012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
