Reviewers: Benedikt Meurer,
Description:
Fixed modulo by a power of 2 on A64.
Actually setting flags before checking them might be a good idea... :-/
Please review this at https://codereview.chromium.org/200113003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/a64/lithium-codegen-a64.cc
Index: src/a64/lithium-codegen-a64.cc
diff --git a/src/a64/lithium-codegen-a64.cc b/src/a64/lithium-codegen-a64.cc
index
982cd8f1d0067152aa6c4c470db0be9c94b82fa0..d80120595853814ef461d76f1a0095626d5e35d8
100644
--- a/src/a64/lithium-codegen-a64.cc
+++ b/src/a64/lithium-codegen-a64.cc
@@ -4139,7 +4139,7 @@ void LCodeGen::DoModByPowerOf2I(LModByPowerOf2I*
instr) {
// Note that this is correct even for kMinInt operands.
__ Neg(dividend, dividend);
__ And(dividend, dividend, Operand(mask));
- __ Neg(dividend, dividend);
+ __ Negs(dividend, dividend);
if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) {
DeoptimizeIf(eq, instr->environment());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
