Reviewers: marja, Michael Starzinger,
Description:
Make invalid LHSs a parse-time (reference) error
This is required by the spec. It also prevents crashes resulting from the
attempt to read type feedback for the RHS of an invalid assignment which
full
codegen never actually allocated info for.
To do: check properly in preparser already.
[email protected],[email protected]
BUG=351658
Please review this at https://codereview.chromium.org/200473003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+133, -192 lines):
M src/a64/full-codegen-a64.cc
M src/arm/full-codegen-arm.cc
M src/factory.h
M src/factory.cc
M src/heap.h
M src/ia32/full-codegen-ia32.cc
M src/messages.js
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
M src/x64/full-codegen-x64.cc
M test/cctest/test-parsing.cc
M test/mjsunit/invalid-lhs.js
A + test/mjsunit/regress/regress-crbug-351658.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
