thx for review!
https://codereview.chromium.org/200343003/diff/1/src/checks.cc
File src/checks.cc (right):
https://codereview.chromium.org/200343003/diff/1/src/checks.cc#newcode96
src/checks.cc:96: } // namespace internal
On 2014/03/14 14:29:19, Michael Starzinger wrote:
nit: Can we get the usual one-line incarnation that closes the full
namespace in
one line? Or is that actually against the style guide?
Done.
https://codereview.chromium.org/200343003/diff/1/src/checks.h
File src/checks.h (right):
https://codereview.chromium.org/200343003/diff/1/src/checks.h#newcode310
src/checks.h:310: void DumpBacktrace();
On 2014/03/14 14:29:19, Michael Starzinger wrote:
nit: Can we get a one-liner comment that this exposed for debugging
purposes?
Otherwise someone might "clean it up" and remove it again.
Done.
https://codereview.chromium.org/200343003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
