Status: Accepted
Owner: [email protected]
CC: [email protected]
Labels: Type-Bug Priority-Medium
New issue 3222 by [email protected]: Improve handling of constants in
the instruction stream on A64
http://code.google.com/p/v8/issues/detail?id=3222
Assembler::debug() and MacroAssembler::CallPrintf() embed constants
directly into the instruction stream. With --print-code, this leads to
random stuff being disassembled. Currently this kind of "works" because
there are basically no assertions in the disassembler, but it severely
hurts any kind of refactoring (e.g. cleaning up the address calculations
regarding Instruction and friends). When we start to assert that e.g. no
pc-relative access/jump goes into the middle of instructions, things start
to break in these constant sections. I have a small, localized CL prepared
(https://codereview.chromium.org/201613005/) to treat these sections like
constant pools, but Ulan pointed out that there might be better ways to
handle this in general, e.g. emit the constants in the "real" constant pool
or the comment section of the reloc info.
In a nutshell: It would be good to hear if I should simply land the CL or
wait for a fix from ARM (hopefully soon, this is blocking some other work).
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
