Addressed comments.
https://codereview.chromium.org/200363002/diff/1/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/200363002/diff/1/src/log.cc#newcode1212
src/log.cc:1212: Object::GetElement(isolate_, args_handle, format[i] -
'0');
On 2014/03/17 16:50:44, Igor Sheludko wrote:
I'm afraid we can hit ASSERT(AllowHeapAllocation::IsAllowed()); inside
GetElement() in case of call from Runtime_Log().
This will not happen, since all callers to Runtime_Log() are from
string.js or regexp.js, which pass an array literal as argument. If
GetElement indeed allocates.
In any case, I also handlified Runtime_Log().
https://codereview.chromium.org/200363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
