thx for review!

https://codereview.chromium.org/203353002/diff/100001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/203353002/diff/100001/include/v8.h#newcode1107
include/v8.h:1107: // alive long enough.
On 2014/03/19 12:04:52, Sven Panne wrote:
I think the comment is out of date. Furthermore, we should note that
if the data
is owned by CachedData, it will be deleted via 'delete[]'.

Updated the comment to be:

If buffer_policy is BufferNotOwned, the caller keeps the ownership of
data and guarantees that it stays alive until the CachedData object is
destroyed. If the policy is BufferOwned, the given data will be deleted
(with delete[]) when the CachedData object is destroyed.

https://codereview.chromium.org/203353002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to