Reviewers: ulan, jochen,
Description:
A64: Restore the stack limit protection to 1KB.
Please review this at https://codereview.chromium.org/206393002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -7 lines):
M src/a64/simulator-a64.h
M src/a64/simulator-a64.cc
Index: src/a64/simulator-a64.cc
diff --git a/src/a64/simulator-a64.cc b/src/a64/simulator-a64.cc
index
d414bf5426e3c83ba509effb5c1f8d342d17d0d8..a401c62d2ebdf6d287b3c265a8c5ef56d92a171f
100644
--- a/src/a64/simulator-a64.cc
+++ b/src/a64/simulator-a64.cc
@@ -359,12 +359,7 @@ uintptr_t Simulator::PopAddress() {
uintptr_t Simulator::StackLimit() const {
// Leave a safety margin of 1024 bytes to prevent overrunning the stack
when
// pushing values.
- // TODO(all): Increase the stack limit protection.
-
- // The margin was decreased to 256 bytes, because we are intensively
using
- // the stack. The stack usage should decrease when our code improves.
Then
- // we can set it to 1024 again.
- return reinterpret_cast<uintptr_t>(stack_limit_) + 256;
+ return reinterpret_cast<uintptr_t>(stack_limit_) + 1024;
}
Index: src/a64/simulator-a64.h
diff --git a/src/a64/simulator-a64.h b/src/a64/simulator-a64.h
index
0d973e835e14bbb8f58a963c25909c7683d63c2a..1ef891a151ecee375870f5e6073f01cc93d1d773
100644
--- a/src/a64/simulator-a64.h
+++ b/src/a64/simulator-a64.h
@@ -833,7 +833,6 @@ class Simulator : public DecoderVisitor {
static const intptr_t stack_protection_size_ = KB;
intptr_t stack_size_;
byte* stack_limit_;
- // TODO(aleram): protect the stack.
Decoder<DispatchingDecoderVisitor>* decoder_;
Decoder<DispatchingDecoderVisitor>* disassembler_decoder_;
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
