On 2014/03/20 13:43:32, ulan wrote:
On 2014/03/20 13:22:17, aandrey wrote:
> On 2014/03/20 13:13:08, ulan wrote:
> > Thanks for fixing. Something seems to be wrong with the Patch Set 4:
it
> changes
> > unrelated lines. Did you accidentally upload with incorrect base?
>
> Seems OK to me:
>
https://codereview.chromium.org/203463011/diff2/40001:60001/src/runtime.cc
Yes, the diff between patch sets is OK, but the diff to the base is off
so I
cannot apply your patch locally:
https://codereview.chromium.org/203463011/diff/60001/src/runtime.cc
https://codereview.chromium.org/download/issue203463011_60001.diff
This is probably because your base is git://github.com/v8/v8.git@master
instead
of http://v8.googlecode.com/svn/branches/bleeding_edge/
Could you please try to rebase and reupload? If that doesn't work send me
a
raw
patch via email and I will upload a CL for you with the correct base.
For future CLs it is probably worth setting up your v8 checkout as
described
in
https://code.google.com/p/v8/wiki/Contributing
Oh I see. Rebased.
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
