Revision: 20131
Author: alexandre.ra...@arm.com
Date: Thu Mar 20 15:25:27 2014 UTC
Log: A64: Restore the stack limit protection to 1KB.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/206393002
http://code.google.com/p/v8/source/detail?r=20131
Modified:
/branches/bleeding_edge/src/a64/simulator-a64.cc
/branches/bleeding_edge/src/a64/simulator-a64.h
=======================================
--- /branches/bleeding_edge/src/a64/simulator-a64.cc Thu Mar 20 10:03:17
2014 UTC
+++ /branches/bleeding_edge/src/a64/simulator-a64.cc Thu Mar 20 15:25:27
2014 UTC
@@ -359,12 +359,7 @@
uintptr_t Simulator::StackLimit() const {
// Leave a safety margin of 1024 bytes to prevent overrunning the stack
when
// pushing values.
- // TODO(all): Increase the stack limit protection.
-
- // The margin was decreased to 256 bytes, because we are intensively
using
- // the stack. The stack usage should decrease when our code improves.
Then
- // we can set it to 1024 again.
- return reinterpret_cast<uintptr_t>(stack_limit_) + 256;
+ return reinterpret_cast<uintptr_t>(stack_limit_) + 1024;
}
=======================================
--- /branches/bleeding_edge/src/a64/simulator-a64.h Thu Mar 20 09:51:19
2014 UTC
+++ /branches/bleeding_edge/src/a64/simulator-a64.h Thu Mar 20 15:25:27
2014 UTC
@@ -833,7 +833,6 @@
static const intptr_t stack_protection_size_ = KB;
intptr_t stack_size_;
byte* stack_limit_;
- // TODO(aleram): protect the stack.
Decoder<DispatchingDecoderVisitor>* decoder_;
Decoder<DispatchingDecoderVisitor>* disassembler_decoder_;
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
