The implementation is looking OK and I couldn't spot any bugs in the
lockstep
synchronization. However we are talking about a synchronization mechanism
that
involves four semaphores, one mutex and one atomic variable. This is
impossible
to audit. That poses two concrete concerns about this CL:
- In the current form there are neither use-cases nor test-cases for this
CL.
How did you test it? Is there a concrete use-case you had in mind for this
mechanism?
- How will all of this work once we move to a system that is based on a job
queue (the thing that Jochen is working on)?
https://codereview.chromium.org/177493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
