Reviewers: Yang,

Message:
As discussed.

Description:
Delete mjsunit/string-oom-slow-* tests.

They are too slow, and there is no feasible way to speed them up.

Please review this at https://codereview.chromium.org/205553005/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+0, -52 lines):
  M test/mjsunit/mjsunit.status
  D test/mjsunit/string-oom-slow-escape.js
  D test/mjsunit/string-oom-slow-json-stringify.js
  D test/mjsunit/string-oom-slow-replace-one-with-string.js
  D test/mjsunit/string-oom-slow-to-uppercase.js


Index: test/mjsunit/string-oom-slow-escape.js
diff --git a/test/mjsunit/string-oom-slow-escape.js b/test/mjsunit/string-oom-slow-escape.js
deleted file mode 100644
index 34088c0efc63659aec6ee0f42ca946d58976eb4a..0000000000000000000000000000000000000000
--- a/test/mjsunit/string-oom-slow-escape.js
+++ /dev/null
@@ -1,14 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-
-var a = '<';
-for (var i = 0; i < 26; i++) a += a;
-a = a + a + a;
-
-function escape_a() {
-  escape(a);
-}
-
-assertThrows(escape_a, RangeError);
Index: test/mjsunit/string-oom-slow-json-stringify.js
diff --git a/test/mjsunit/string-oom-slow-json-stringify.js b/test/mjsunit/string-oom-slow-json-stringify.js
deleted file mode 100644
index 2f9965599a65598ebcf98c661a1d292ebbd937e0..0000000000000000000000000000000000000000
--- a/test/mjsunit/string-oom-slow-json-stringify.js
+++ /dev/null
@@ -1,13 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-var a = 'a';
-for (var i = 0; i < 20; i++) a += a;
-for (var i = 0; i < 8; i++) a = [a, a];
-
-function stringify() {
-  JSON.stringify(a);
-}
-
-assertThrows(stringify, RangeError);
Index: test/mjsunit/string-oom-slow-replace-one-with-string.js
diff --git a/test/mjsunit/string-oom-slow-replace-one-with-string.js b/test/mjsunit/string-oom-slow-replace-one-with-string.js
deleted file mode 100644
index bfcbe0f7275efa60d3dda54d81fbc6c567395832..0000000000000000000000000000000000000000
--- a/test/mjsunit/string-oom-slow-replace-one-with-string.js
+++ /dev/null
@@ -1,12 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-var a = 'a';
-for (var i = 0; i < 27; i++) a += a;
-
-function replace() {
-  a.replace('a', a);
-}
-
-assertThrows(replace, RangeError);
Index: test/mjsunit/string-oom-slow-to-uppercase.js
diff --git a/test/mjsunit/string-oom-slow-to-uppercase.js b/test/mjsunit/string-oom-slow-to-uppercase.js
deleted file mode 100644
index 79f975bd0d400f979fc9d0722c2255bc814654b0..0000000000000000000000000000000000000000
--- a/test/mjsunit/string-oom-slow-to-uppercase.js
+++ /dev/null
@@ -1,12 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-var s = "\u00df";  // ß
-for (var i = 0; i < 27; i++) s += s;
-
-function upper() {
-  s.toUpperCase();
-}
-
-assertThrows(upper, RangeError);
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index 9497094ec16d8ce9d733b3be5682bbe9060addae..05f9dd385cf40c98470cdfc03bd4189dcdc9d5f0 100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -44,7 +44,6 @@
   # When that bug is fixed, revert the expectation to:
# Skip long running test in debug and allow it to timeout in release mode.
   # regress/regress-524: [PASS, TIMEOUT, ['mode == debug', SKIP]],
-  'string-oom-slow-*': [PASS, SLOW, ['mode == debug', SKIP]],

   # This test non-deterministically runs out of memory on Windows ia32.
   'regress/regress-crbug-160010': [SKIP],


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to