LGTM with comments.
https://codereview.chromium.org/207613004/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/207613004/diff/1/src/builtins.cc#newcode957
src/builtins.cc:957: // This is the slow path. We are going to move the
elemetns to the left
nit: s/elemetns/elements/
https://codereview.chromium.org/207613004/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/207613004/diff/1/src/mark-compact.cc#newcode679
src/mark-compact.cc:679: }
nit: Indentation is off.
https://codereview.chromium.org/207613004/diff/1/src/mark-compact.h
File src/mark-compact.h (right):
https://codereview.chromium.org/207613004/diff/1/src/mark-compact.h#newcode741
src/mark-compact.h:741: bool CanMoveObjectStart(HeapObject* object);
nit: Shouldn't this actually be a predicate on the Heap class instead of
the MarkCompactCollector class?
https://codereview.chromium.org/207613004/diff/1/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/207613004/diff/1/src/spaces.h#newcode478
src/spaces.h:478: PARALLEL_SWEEPING_FINALIZE,
Please add a comment explaining the semantics of this new state above.
Also please leave a comment that the order of the constants is important
because we use them for range checks.
https://codereview.chromium.org/207613004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
