Reviewers: Michael Starzinger,
Description:
Use HType::Tagged when allocating elements.
[email protected]
Please review this at https://codereview.chromium.org/201573010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -4 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
8705f782a2ed1814b7b4cd8f990eee4eda4c4ce5..2484a09506302141e63c5051de43426dd4bd89b7
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -2309,7 +2309,7 @@ HValue*
HGraphBuilder::BuildAllocateElements(ElementsKind kind,
PretenureFlag pretenure_flag = !FLAG_allocation_site_pretenuring ?
isolate()->heap()->GetPretenureMode() : NOT_TENURED;
- return Add<HAllocate>(total_size, HType::JSArray(), pretenure_flag,
+ return Add<HAllocate>(total_size, HType::Tagged(), pretenure_flag,
instance_type);
}
@@ -2615,11 +2615,11 @@ HValue*
HGraphBuilder::BuildCloneShallowArray(HValue* boilerplate,
HValue* object_elements;
if (IsFastDoubleElementsKind(kind)) {
HValue* elems_size =
Add<HConstant>(FixedDoubleArray::SizeFor(length));
- object_elements = Add<HAllocate>(elems_size, HType::JSArray(),
+ object_elements = Add<HAllocate>(elems_size, HType::Tagged(),
NOT_TENURED, FIXED_DOUBLE_ARRAY_TYPE);
} else {
HValue* elems_size = Add<HConstant>(FixedArray::SizeFor(length));
- object_elements = Add<HAllocate>(elems_size, HType::JSArray(),
+ object_elements = Add<HAllocate>(elems_size, HType::Tagged(),
NOT_TENURED, FIXED_ARRAY_TYPE);
}
Add<HStoreNamedField>(object, HObjectAccess::ForElementsPointer(),
@@ -8533,7 +8533,7 @@ void
HOptimizedGraphBuilder::GenerateTypedArrayInitialize(
HValue* elements =
Add<HAllocate>(
Add<HConstant>(ExternalArray::kAlignedSize),
- HType::JSArray(),
+ HType::Tagged(),
NOT_TENURED,
external_array_map->instance_type());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
